Open
Conversation
IRooc
force-pushed
the
example/texture_sprite_anim
branch
3 times, most recently
from
88b9102 to
d69676f
Compare
IRooc
force-pushed
the
example/texture_sprite_anim
branch
from
d69676f to
4701690
Compare
jkisor
reviewed
Feb 18, 2024
Comment on lines
+301
to
+303
| let maxWait = 1000; | ||
| while(maxWait >= 0) | ||
| maxWait--; |
Contributor
There was a problem hiding this comment.
Tricky -- I think I found a way without waiting. #37
EDIT: Well, this example uses width/height data returned from LoadTexture -- which is yet to be implemented.
Author
There was a problem hiding this comment.
Only synchronous option is the deprecated XMLHttpRequest one
function getImageDimensions(url) {
let xhr = new XMLHttpRequest();
xhr.overrideMimeType('text/plain; charset=x-user-defined'); //needed to not have unicode just ascii for the header part
xhr.open('GET', url, false); // False for synchronous request
xhr.send();
if (xhr.status !== 200) {
throw new Error('Failed to fetch image: ' + xhr.status);
}
let data = xhr.responseText;
if (data.substr(1, 3) === 'PNG') {
let ihdr = data.indexOf('IHDR');
if (ihdr === -1) {
throw new Error('IHDR chunk not found');
}
var uint8 = Uint8Array.from(data.split("").map(x => x.charCodeAt()))
let width = uint8[ihdr + 4] << 24 | uint8[ihdr + 5] << 16 | uint8[ihdr + 6] << 8 | uint8[ihdr + 7];
let height = uint8[ihdr + 8] << 24 | uint8[ihdr + 9] << 16 | uint8[ihdr + 10] << 8 | uint8[ihdr + 11];
return { width, height };
}
throw new Error('Not a supported image');
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardest thing in web still is loading an image and having the width and height available for you in a single function.
For the other part it all works, but if the image initially is not loaded quick enough it will be a wrong sprite offset because it falls back to 256 for width and height.
And yes Tsoding, i used the
x = 0 || 256operator ....We should credit the Sprite Designer (which is done in the demo but in the source as well)
(c) Scarfy sprite by Eiden Marsal